Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect name for health filter in catalog name #1993

Conversation

mainawycliffe
Copy link
Contributor

Fixes #1992

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
flanksource-ui ✅ Ready (Inspect) Visit Preview Jun 5, 2024 3:00pm

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit 2e9a590
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/66607cc008013500089c1fe0
😎 Deploy Preview https://deploy-preview-1993--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit 2e9a590
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/66607cc0d8beb9000895f75a
😎 Deploy Preview https://deploy-preview-1993--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit 2e9a590
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/66607cc0d50d250008cdc90c
😎 Deploy Preview https://deploy-preview-1993--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@moshloop
Copy link
Member

moshloop commented Jun 3, 2024

@mainawycliffe this does not appear to work

@mainawycliffe
Copy link
Contributor Author

@moshloop did you mean this or something else ->
image

@mainawycliffe mainawycliffe force-pushed the 1992-Catalog-health-filter-is-not-shown-even-though-its-selected-when-clicking-on-health-in-catalog-summary branch from 45e84f6 to 95b0b0c Compare June 4, 2024 12:27
@mainawycliffe mainawycliffe force-pushed the 1992-Catalog-health-filter-is-not-shown-even-though-its-selected-when-clicking-on-health-in-catalog-summary branch from 95b0b0c to 11b06a0 Compare June 4, 2024 13:28
@moshloop
Copy link
Member

moshloop commented Jun 5, 2024

@mainawycliffe - I get a getConfigStatusColor is not defined error

@mainawycliffe
Copy link
Contributor Author

@moshloop let me take a look

@mainawycliffe mainawycliffe force-pushed the 1992-Catalog-health-filter-is-not-shown-even-though-its-selected-when-clicking-on-health-in-catalog-summary branch from 11b06a0 to 20fdbed Compare June 5, 2024 12:18
@mainawycliffe mainawycliffe force-pushed the 1992-Catalog-health-filter-is-not-shown-even-though-its-selected-when-clicking-on-health-in-catalog-summary branch from fd19058 to 005761a Compare June 5, 2024 14:55
fix: fix issue with config summary

chore: fix health filter link

fix: fix filters not working
@mainawycliffe mainawycliffe force-pushed the 1992-Catalog-health-filter-is-not-shown-even-though-its-selected-when-clicking-on-health-in-catalog-summary branch from 005761a to 2e9a590 Compare June 5, 2024 14:57
@moshloop moshloop merged commit df14917 into main Jun 6, 2024
14 of 16 checks passed
@moshloop moshloop deleted the 1992-Catalog-health-filter-is-not-shown-even-though-its-selected-when-clicking-on-health-in-catalog-summary branch June 6, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog health filter is not shown (even though its selected) when clicking on health in catalog summary
2 participants